Solved Showing a custom trading screen

Hello! I'm trying to make it so villagers can show custom trades! I'd just like to know how to show a trading screen even when a villager hasn't been clicked AND how to change a villagers trades.

Thank you!

 

maybe making your own implementation of MerchantInventory?

 

Ooh! How would one go about doing that?

 

either extends CraftInventoryMerchant or implement MerchantInventory

 

But hhhhhooooowwwwwww???

 

no clue if it will work, but you could try this:

Code:java

class MerchantInventory2 implements MerchantInventory
{
 
    @Override
    public int getSize() {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public int getMaxStackSize() {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public void setMaxStackSize(int i) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public String getName() {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public ItemStack getItem(int i) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public void setItem(int i, ItemStack is) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public HashMap<Integer, ItemStack> addItem(ItemStack... iss) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public HashMap<Integer, ItemStack> removeItem(ItemStack... iss) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public ItemStack[] getContents() {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public void setContents(ItemStack[] iss) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public boolean contains(int i) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public boolean contains(Material mtrl) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public boolean contains(ItemStack is) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public boolean contains(int i, int i1) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public boolean contains(Material mtrl, int i) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public boolean contains(ItemStack is, int i) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public HashMap<Integer, ? extends ItemStack> all(int i) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public HashMap<Integer, ? extends ItemStack> all(Material mtrl) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public HashMap<Integer, ? extends ItemStack> all(ItemStack is) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public int first(int i) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public int first(Material mtrl) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public int first(ItemStack is) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public int firstEmpty() {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public void remove(int i) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public void remove(Material mtrl) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public void remove(ItemStack is) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public void clear(int i) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public void clear() {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public List<HumanEntity> getViewers() {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public String getTitle() {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public InventoryType getType() {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public InventoryHolder getHolder() {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public ListIterator<ItemStack> iterator() {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
    @Override
    public ListIterator<ItemStack> iterator(int i) {
        throw new UnsupportedOperationException("Not supported yet.");
    }
 
}

Obviously, you would have to implement the methods

 

I doubt that will work, but I guess it is worth a try! I am looking through the cb source right now to see how the server does it, and I will report back here if I find anything useful

Ok, this explains all of the packets involved:
http://www.wiki.vg/Protocol#Open_Window_.280x64.29
The window id is 6 for villager trading windows (look at handleOpenWindow in NetClientHandler in mcp, case 6).
I am trying to get a working code example for you ready.

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

jtjj222 this does not handle trading inventories: http://www.wiki.vg/Inventory#Windows

 

I know, there are other packets for that, but it's a start, and it's the only solution offered so far...

Ok, so I can spawn a trading window, now I will work on getting trading to work.
View attachment 11740

Ok, I made a custom trade. View attachment 11743
(1 glass for 1 glass)

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

^fantastic idea. Might have to figure out how to do that and implement a way for players to trade when in a certain area

 

and how did you do this? Using the method I described before?

 

Nope

Code:java

 
public boolean onCommand(CommandSender sender, Command cmd, String label, String[] args){
 
/*******Get a trading window ready***************/
Packet100OpenWindow packet = new Packet100OpenWindow();
packet.a = windowId; //window id
packet.b = 6; //inventory type
packet.c = "Title"; //title
packet.d = 1; //inventory count
/******************************/
 
/*******Send the packet to open a trading window**********/
EntityPlayer p = ((CraftPlayer)((Player)sender)).getHandle();
p.netServerHandler.sendPacket(packet);
/******************************/
 
/********Prepare the offers**************/
MerchantRecipeList r = new MerchantRecipeList();
 
//add a recipie to the list
//The player can select between these using the arrows
r.a(new MerchantRecipe(new ItemStack(Material.GLASS.getId(),1, 0), new ItemStack(Material.STONE.getId(),2,0), new ItemStack(Material.THIN_GLASS.getId(),3,0)));
r.a(new MerchantRecipe(new ItemStack(Material.GLASS.getId(),1, 0), new ItemStack(Material.GLASS.getId(),20,0)));
/**NOTE: ItemStack is the net.minecraft one, not the bukkit one**/
/**The constructor for ItemStack takes the item id, number of items in the stack, and damage*/
/******************************/
 
/****Send the trading offer list using custom payload packet*****/
        try {
 
       /******Prepare a CustomPayloadPacket***********/
            ByteArrayOutputStream buffer = new ByteArrayOutputStream();
            DataOutputStream out = new DataOutputStream(buffer);
 
            /*******Write the window id**********/
            out.writeInt(this.windowId);
 
            /******Then write the offer*************/
            r.a(out);
 
            p.netServerHandler.sendPacket(new Packet250CustomPayload("MC|TrList", buffer.toByteArray()));
            /******************************/
 
        }
 
        catch (IOException e) {
            e.printStackTrace();
        }
 
        /*****We're done here!***********/
 
return true;
}
 

If anyone wants to make a shop plugin with me like this, let me know

Just to clarify, this is what the result of the code I posted looks like (note the arrow being active):
This is the first trade offer
View attachment 11744

EDIT by Moderator: merged posts, please use the edit button instead of double posting.

 

jtjj222
I would be interested in helping on a plugin with you. PM me if you need my skype info or email.

 

jtjj222 nice code. Where did you get the custom packet from (like, any resources)?

 

I looked through mcp to figure out how to do everything for that. For the custom packet, I found that code in EntityPlayerMP.

 

http://dev.bukkit.org/server-mods/tradeshop/

Created a project for it with @jfjj222

Let me or him know if you want to help out

 

I would Like to help out.

 

I wanna help add me on skype thelegacyunlocking | i can do gfx and all the video's and advertising etc... | and maby a bit of coding

 

I wrote a library to simplify this for anyone who wants to spawn an npc window:
http://forums.bukkit.org/threads/li...-villager-trades-quick-easy-and-clean.111824/

 

LegacyUnlocking I added you on skype

 

Thanks for the code! Also if you guys are going to make a plugin, please make your own thread

Thanks!