Solved Splitting a List

i am trying to split my config file, but i am having trouble. My code is below.

Code:java

 List<String> list = getConfig().getStringList("Items");
String[] splited = list.split(",");
for(String items : list) {
String name = list.split(",")[0];;
String amount = list.split(",")[1];
String price = list.split(",")[2];

 

Could you explain what you try to achieve by "Splitting" a list, because it doesn't make much sense to me. Also what is your YML file (for reference).

 

Stoux my yaml file is the default config. I am trying to retrieve the item,amount,price from the config. All 3 of those are on the same line of the list and i am trying to separate them.

 

I have a really hard time figuring out why you should do it like this. If you just save it in a more logical way in the YML, there's no need for splitting.

Code:

items:
  axe:
    price: 10
    amount: 2
  sword:
    price: 12
    amount: 8

If you do it like this you can easily access any value of an item. First you get the ConfigurationSection "items". Once you have that you get all the keys. Each key is an item, and for each item you can the do config.getInt(key + ".price") which will return the price.

 

My client wants a shop plugin, so i am allowing the potential to have a ton of items in the shop

 

Reading configuration files should be on on server start, not in-game, in which case, it doesnt really matter very much on how long it takes to read the file (or multiple files). It may take 5 or 10 seconds, but its startup time, so it doesnt matter. This is one of the few areas of the plugin where you should be encouraged to push any lengthy work, (your exact situation) because in-game performance will not be affected. They shouldnt be read from whilst the server is live. My point is that you should be able to use yaml as intended, at the expense of a large file, rather than trying to roll your own smaller file-size implementation.

If and when you write to the file, it should be done asynchronously, so again, who cares if it takes half a second, your internal representation will already be updated with the correct data. Just lock the file as to avoid any potential problems. I'm not sure if marking the method synchronized will be enough.

 

jayfella Here is my entire code. I just created a method that is run in the onEnable() method. It was just too hard to read when it was in onEnable();

Code:java

package me.connor.shop;
 
import java.util.Arrays;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.DyeColor;
import org.bukkit.World;
import org.bukkit.entity.Player;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.inventory.meta.ItemMeta;
import org.bukkit.material.Wool;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin {
    Inventory inv;
    private ItemStack c, s, a;
 
 
    public void onEnable() {
        saveDefaultConfig();
        getCommand("shop").setExecutor(new ShopCommands(this));
        Inv();
    }
 
    public void onDisable() {
        reloadConfig();
        saveConfig();
    }
 
    public void Inv() {
        inv = Bukkit.getServer().createInventory(null, 27, "Items");
        ItemStack item;
        List<String> list = this.getConfig().getStringList("items");
        for(String s : list) {
            String both[] = s.split(",");
            String name = both[0]; // item name
            String amount = both[1]; // quantity of an item
            String price = both[2]; // price of item
            item = createItem(DyeColor.LIME, ChatColor.GREEN + name, amount, price);
            if(!inv.contains(item)){
                inv.setItem(inv.firstEmpty(), item);
            }
        }
    }
 
    private ItemStack createItem(DyeColor dc, String name, String price, String amount) {
        ItemStack i = new Wool(dc).toItemStack(1);
        ItemMeta im = i.getItemMeta();
        im.setDisplayName(name);
        im.setLore(Arrays.asList(ChatColor.GRAY + "$Quantity" + amount));
        im.setLore(Arrays.asList(ChatColor.GRAY + "$Costs" + price));
        i.setItemMeta(im);
        return i;
    }
 
    public void showWorld(Player p) {
        p.openInventory(inv);
    }
 
}