Solved Value Saving Help

So here is my line of code, onPlayerJoin this line is executed:


plugin.getConfig().set(player.getName() + ".FirstJoinTime", Long.valueOf(System.currentTimeMillis()));

and after that I save and reload the config, but if I look at the config file the information I expect to be under the players name and FirstJoinTime is not there at all

 

The config file is empty? Maybe you aren't saving it correctly. Any exceptions?

 

PogoStick29

I run this right after that command is issued:

plugin.saveConfig();
plugin.reloadConfig();

but no, no exceptions are thrown at all. Just for some mysterious reason it's not there.

Here's my whole block of code just in case it helps:

Code:java

    @EventHandler
    public void onPlayerJoin(PlayerJoinEvent event) {
        player = event.getPlayer();
        unique = Bukkit.getOfflinePlayers().length;
 
        if (player.hasPlayedBefore() == false && plugin.getConfig().getString(player.getName()) == null) {
            event.setJoinMessage(stringCleaner(plugin.getConfig().getString("messages.NEWPLAYERJOIN")));
 
            plugin.getConfig().set(player.getName(), Long.valueOf(System.currentTimeMillis()));
            plugin.getConfig().set(player.getName() + ".FirstJoinTime", Long.valueOf(System.currentTimeMillis()));
            plugin.saveConfig();
            plugin.reloadConfig();
 
        } else if (!player.hasPlayedBefore() || plugin.getConfig().getString(player.getName()) == null) {
            event.setJoinMessage(stringCleaner(plugin.getConfig().getString("messages.NODATAJOIN")));
 
            plugin.getConfig().set(player.getName(), Long.valueOf(System.currentTimeMillis()));
            plugin.getConfig().set(player.getName() + ".FirstJoinTime", Long.valueOf(System.currentTimeMillis()));
            plugin.saveConfig();
            plugin.reloadConfig();
 
        } else {
 
            //more stuff
 
        }
    }

 

That is very strange. Just as a side note, you are setting both the name and name.FirstJoinTime to values, which isn't what you want to do. Also, System.currentTimeMillis() should be a long, so you don't need Long.valueOf().

 

PogoStick29



Well I actually do want to set the name to a value, and then set name.FirstJoinTime to a value, but it's not working and I don't know why.

Also thank you for telling me about the Long.valueOf()

EDIT: The name itself does get the value assigned, but I need the name.FirstJoinPlus to get the value as well which is what isn't happening. That's how I know it is saving and reloading correctly.

 

First off, you need a PlayerLoginEvent, not a PlayerJoinEvent, to check if a player has never played before.

Second, in the first statement, you are checking if the player has not played before and they are not in the config. In the second statement, you are check if the player has not played before or they are not in the config. Delete the second statement or change it.

 

Umm using onPlayerJoin works for the hasplayedbefore check as well. But also those lines will both be staying because they do separate things. If it's "and" then it means the player has never played before. If it's "or" then that means they've played before, but not since my plugin was installed on the server. I do realize I can change them a little bit to do the same thing but I still need to fix the problem of the FirstJoinTime.


I got it to mark the FirstJoinTime.

But now when the user quits the game I have it save the time they left to their name, and that deletes FirstJoinTime.

How do I change the long after the name instead of making a new one?

 

1. I am 99% sure you need a PlayerLoginEvent, but if it works for you, great.
2. Remove the !player.hasPlayedBefore() part from your second if statement, because you don't need it and there could be some cases of players' names being in the config without them playing.
3. Are you saving it to FirstJoinTime or another variable?

 

I'm saving it to FirstJoinTime in the config.

So right now I have it so that when the player joins it goes:

playername:
FirstJoineTime: 209486902486


but when the player logs out I run this bit of code:

plugin.getConfig().set(player.getName(), Long.valueOf(System.currentTimeMillis()));

to save their logout time.


After that the config name gets changed to this:

playername: 989028590234643

so the FirstJoinTime value is deleted.

 

I believe that is because by setting a variable, you are deleting anything under it. The easiest way to solve this is to store the logout time to another variable under playername.

playername:
FirstJoinTime: 209486902486
LastLogoutTime: 696969696969

 

Alright, I'll just do that then. Thank you.

 

No problem.

 

Okay so again it's the same problem.

On the player join it sets it to

playername:
FirstJoinTime: 98402u6946

but then on logout it deletes that and does


playername:
LastJoinTime: 9842609

 

Can you paste the modified code?

 

For some reason it appears that the jar file didn't update in my plugins folder correctly, so it actually does work. Nevermind.