Very High Timings

Hello, so recently I found out my server was lagging a lot.
I used the /timings command to get my timings.
I found out that one plugin, custom coded, has some extremely high timings.
Could you please help me find out what the issue is?
Timings:
ChooseableVoteRewards v1.0.0
InventoryClickEvent (and others) Time: 77291485000 Count: 121415 Avg: 636589
InventoryCloseEvent Time: 15065844000 Count: 18018 Avg: 836155
Total time 92357329000 (92s)
Code:

Code:java

package me.j0ach1mmall3.ChoosableVoteRewards;
 
import java.util.ArrayList;
import java.util.List;
 
import org.bukkit.Bukkit;
import org.bukkit.ChatColor;
import org.bukkit.Material;
import org.bukkit.command.Command;
import org.bukkit.command.CommandSender;
import org.bukkit.command.ConsoleCommandSender;
import org.bukkit.entity.Player;
import org.bukkit.event.EventHandler;
import org.bukkit.event.EventPriority;
import org.bukkit.event.Listener;
import org.bukkit.event.inventory.InventoryClickEvent;
import org.bukkit.event.inventory.InventoryCloseEvent;
import org.bukkit.inventory.Inventory;
import org.bukkit.inventory.ItemStack;
import org.bukkit.plugin.java.JavaPlugin;
 
public class Main extends JavaPlugin implements Listener {
    Inventory VoteInv;
    List<Integer> VoteItemsAmounts = new ArrayList<Integer>();;
    List<String> VoteItemsIDs = new ArrayList<String>();;
    String KickMsg;
    String InvName;
    public void onEnable(){
        getConfig().options().copyDefaults(true);
        saveConfig();
        this.getServer().getPluginManager().registerEvents(this, this);
        List<String> VoteItemsIDs = getConfig().getStringList("VoteItemsIDs");
        List<Integer> VoteItemsAmounts = getConfig().getIntegerList("VoteItemsAmounts");
        String InvName = getConfig().getString("InvName").replaceAll("&", "§");
        String KickMsg = getConfig().getString("KickMsg").replaceAll("&", "§");
    }
 
    public boolean onCommand(CommandSender sender, Command cmd, String label, String[] a) {
        if(cmd.getName().equalsIgnoreCase("voted")){
            reloadConfig();
            VoteItemsIDs = getConfig().getStringList("VoteItemsIDs");
            VoteItemsAmounts = getConfig().getIntegerList("VoteItemsAmounts");
            String InvName = getConfig().getString("InvName").replaceAll("&", "§");
            if (sender instanceof Player){
                Player p = (Player) sender;
                if (p.hasPermission("cvr.voted")){
                    if (a.length > 0){
                        VoteInv = Bukkit.getServer().createInventory(null, 9, InvName);
                        Player voted = Bukkit.getServer().getPlayer(a[0]);
                        for (int x = 0; x < VoteItemsIDs.size(); x++){
                            String VoteItemID = VoteItemsIDs.get(x);
                            String[] IDAndData = VoteItemID.split(":");
                            if (IDAndData.length == 2){
                                VoteInv.setItem(x, new ItemStack(Material.getMaterial(Integer.parseInt(IDAndData[0])), VoteItemsAmounts.get(x), (short) Integer.parseInt(IDAndData[1])));
                            } else if (IDAndData.length == 1){
                                VoteInv.setItem(x, new ItemStack(Material.getMaterial(Integer.parseInt(IDAndData[0])), VoteItemsAmounts.get(x)));
                            }                        }
                        voted.openInventory(VoteInv);
                    } else {
                        p.sendMessage("§4Please specify a name");
                    }
                } else {
                    p.sendMessage("§4You do not have permission to do this");
                }   
            } else if (sender instanceof ConsoleCommandSender){
                if (a.length > 0){
                    VoteInv = Bukkit.getServer().createInventory(null, 9, InvName);
                    Player voted = Bukkit.getServer().getPlayer(a[0]);
                    for (int x = 0; x < VoteItemsIDs.size(); x++){
                        String VoteItemID = VoteItemsIDs.get(x);
                        String[] IDAndData = VoteItemID.split(":");
                        if (IDAndData.length == 2){
                            VoteInv.setItem(x, new ItemStack(Material.getMaterial(Integer.parseInt(IDAndData[0])), VoteItemsAmounts.get(x), (short) Integer.parseInt(IDAndData[1])));
                        } else if (IDAndData.length == 1){
                            VoteInv.setItem(x, new ItemStack(Material.getMaterial(Integer.parseInt(IDAndData[0])), VoteItemsAmounts.get(x)));
                        }
                    }
                    voted.openInventory(VoteInv);
                } else {
                    ConsoleCommandSender c = Bukkit.getServer().getConsoleSender();
                    c.sendMessage(ChatColor.DARK_RED + "Please specify a name!");
                }
            }
        }
        return true;
    }
    @EventHandler(priority=EventPriority.LOWEST)
    public void onInvClose(InventoryCloseEvent e){
        reloadConfig();
        String InvName = getConfig().getString("InvName").replaceAll("&", "§");
        String InvName1 = e.getInventory().getName();
        if (InvName1 != null){
            if (InvName1.equals(InvName)){
                final Player p = (Player) e.getPlayer();
                Bukkit.getScheduler().scheduleSyncDelayedTask(this, new Runnable() {
                    public void run() {
                        p.openInventory(VoteInv);
                    }
                });
            }
        }
    }
    @SuppressWarnings("deprecation")
    @EventHandler(priority=EventPriority.LOWEST)
    public void onPlayerClickInv(InventoryClickEvent e){
        String InvName1 = e.getInventory().getName();
        Player p = (Player) e.getWhoClicked();
        reloadConfig();
        String InvName = getConfig().getString("InvName").replaceAll("&", "§");
        String KickMsg = getConfig().getString("KickMsg").replaceAll("&", "§");
        if (InvName1 != null){
            if (InvName1.equals(InvName)){
                if ((e.getCurrentItem() != null) && (e.getCurrentItem().getType() != Material.AIR) && (VoteInv.contains(e.getCurrentItem()))){
                    ItemStack is = e.getCurrentItem();
                    e.setCancelled(true);
                    p.closeInventory();
                    p.getInventory().addItem(is);
                    p.updateInventory();
                    p.kickPlayer(KickMsg);
                }
            }
        }
    }
}

 

You are reloading your config on evry inventory click, on every inventory close and on every "vote" command.
Why?
You only need to reload the config if you have changed the file outside of your plugin. For example after editing it directly with a text editor.
I don't know if this is the reason for your lags. But it surely can be a source of lag with alot of players online who trigger those events costantly.

Also: You should form the habit of checking the major conditions in an event handler first.
Not the minor ones.
You goal should always be to determine whether your EventHandler actions should be run or not as "fast" or as "effortless" as possible.
Example: In your InventoryClickEvent, instead of first doing all this stuff:

Code:

 String InvName1 = e.getInventory().getName();
Player p = (Player) e.getWhoClicked();
reloadConfig();
String InvName = getConfig().getString("InvName").replaceAll("&", "§");
String KickMsg = getConfig().getString("KickMsg").replaceAll("&", "§");
if (InvName1 != null){
if (InvName1.equals(InvName)){

check the superior conditions first:

Code:

if ((e.getCurrentItem() != null) && (e.getCurrentItem().getType() != Material.AIR) && (VoteInv.contains(e.getCurrentItem()))){

Because then you can leave the handler quickly if those conditions do not apply, without creating a lot of instances and reading your config and stuff and afterwars discovering you have to leave the handler anyway.
This induces unneccessary CPU load and consumes time.

 

Well, the reloading was to not have a reload command, because I wanted to keep the plugin as simple as possible.

 

j0ach1mmall3
But why are you even reloading the config? There's no need to do it.

 

To not have a reload command....

 

j0ach1mmall3 Why would you need to reload the config in the first place though?

 

What Rocoty is saying is that you only need to save your config when you stop the server, so that any changes made to it while the server was running are applied and saved to disk

 

Because the Data in the config specifies the items in the inventory

 

j0ach1mmall3

Excellent, you still don't seem to get the point.

Simplicity is not an excuse for laziness/poor performance. I would take a plugin that has to be told to reload over one that performs disk read/writes every time I execute a command any day.

 

So what do I have to change then hmm?

 

Remove the "reloadConfig()" from your event handlers. ^^
If you need such a function, make a specific reload command.
As already mentioned: Reloading is only neccessary when you modified the config file outside of the game while the game is running. This is not a common case. So a dedicated reload command is a good thing.
Reloading does a read from disk, which is slow. You don't want to execute slow actions if it's not necessary.
Expeccially when you are already expieriencing lag from inefficiently written plugin code.

 

Hmm, I'll just make them restart their server if they want to reload their config.